sync: update from private repo (0dd1a8e)
CI / build-and-test (push) Has been cancelled

This commit is contained in:
oss-sync
2026-06-11 11:50:39 +00:00
parent 3b1645cc91
commit c5be399fdd
15 changed files with 337 additions and 65 deletions
+17
View File
@@ -5,6 +5,7 @@ import { ToolDef } from '../../llm/openai-compat.js';
import type { ToolContext, ToolResult } from './core.js';
import { resolveAndGuard, resolveOutputPathWithin } from './core.js';
import { logger } from '../../logger.js';
import { recordLlmUsage } from '../../llm/usage-recorder.js';
// --- Supported image extensions ---
@@ -310,7 +311,9 @@ export async function callVisionModel(
}
const json = (await response.json()) as {
model?: string;
choices?: Array<{ message?: { content?: string } }>;
usage?: { prompt_tokens?: number; completion_tokens?: number };
};
const content = json.choices?.[0]?.message?.content;
@@ -318,6 +321,20 @@ export async function callVisionModel(
return { output: 'Vision API returned no content', isError: true };
}
// This vision call is a raw fetch outside OpenAICompatClient, so it would
// otherwise miss the per-user usage ledger. Record it directly (issue
// #499). Vision uses its own endpoint directly (never the gateway).
let route = 'unknown';
try { route = new URL(visionBaseUrl).host || 'unknown'; } catch { /* keep 'unknown' */ }
recordLlmUsage({
userId: ctx.userId ?? 'local',
source: 'direct',
model: json.model || visionModel,
route,
tokensIn: json.usage?.prompt_tokens ?? 0,
tokensOut: json.usage?.completion_tokens ?? 0,
});
return { output: content, isError: false };
} catch (e) {
if ((e as Error).name === 'AbortError') {
@@ -0,0 +1,65 @@
/**
* ReadImage vision call records to the per-user usage ledger (issue #499).
* The vision call is a raw fetch outside OpenAICompatClient, so it records
* directly via recordLlmUsage.
*/
import { describe, it, expect, vi, afterEach } from 'vitest';
import { callVisionModel } from './image.js';
import type { ToolContext } from './core.js';
import { setLlmUsageRecorder, type LlmUsageEvent } from '../../llm/usage-recorder.js';
function ctx(): ToolContext {
return {
workspacePath: '/tmp',
userId: 'u1',
toolsConfig: { visionBaseUrl: 'http://vision-host:11434/v1', visionModel: 'qwen2-vl' },
} as unknown as ToolContext;
}
afterEach(() => {
setLlmUsageRecorder(null);
vi.unstubAllGlobals();
});
describe('callVisionModel usage recording', () => {
it('records a direct usage event with the vision host as route', async () => {
const events: LlmUsageEvent[] = [];
setLlmUsageRecorder((e) => events.push(e));
vi.stubGlobal('fetch', vi.fn().mockResolvedValue({
ok: true,
json: async () => ({
model: 'qwen2-vl',
choices: [{ message: { content: 'a cat' } }],
usage: { prompt_tokens: 250, completion_tokens: 12 },
}),
}));
const res = await callVisionModel('data:image/png;base64,xxx', 'describe', ctx());
expect(res.isError).toBe(false);
expect(events).toHaveLength(1);
expect(events[0]).toEqual({
userId: 'u1', source: 'direct', model: 'qwen2-vl', route: 'vision-host:11434',
tokensIn: 250, tokensOut: 12,
});
});
it('records zero tokens when the vision response omits usage', async () => {
const events: LlmUsageEvent[] = [];
setLlmUsageRecorder((e) => events.push(e));
vi.stubGlobal('fetch', vi.fn().mockResolvedValue({
ok: true,
json: async () => ({ choices: [{ message: { content: 'x' } }] }),
}));
await callVisionModel('data:image/png;base64,xxx', '', ctx());
expect(events[0]).toMatchObject({ tokensIn: 0, tokensOut: 0, model: 'qwen2-vl' });
});
it('does not record on a vision API error', async () => {
const events: LlmUsageEvent[] = [];
setLlmUsageRecorder((e) => events.push(e));
vi.stubGlobal('fetch', vi.fn().mockResolvedValue({ ok: false, status: 500, text: async () => 'boom' }));
const res = await callVisionModel('data:image/png;base64,xxx', '', ctx());
expect(res.isError).toBe(true);
expect(events).toHaveLength(0);
});
});